Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show toast notifications when copying links or images #26970

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Dec 10, 2024

Resolves brave/brave-browser#42782

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick self-assigned this Dec 10, 2024
@emerick emerick force-pushed the emerick-dont-show-link-or-image-toasts branch from d815880 to f0c6f59 Compare December 10, 2024 21:45
@emerick emerick force-pushed the emerick-dont-show-link-or-image-toasts branch from f0c6f59 to f74bacb Compare December 10, 2024 23:14
@emerick emerick marked this pull request as ready for review December 10, 2024 23:15
@emerick emerick requested a review from a team as a code owner December 10, 2024 23:16
@emerick emerick merged commit 8aeb9e5 into master Dec 11, 2024
18 checks passed
@emerick emerick deleted the emerick-dont-show-link-or-image-toasts branch December 11, 2024 12:30
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 11, 2024
brave-builds added a commit that referenced this pull request Dec 11, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.92

@LaurenWags
Copy link
Member

LaurenWags commented Dec 12, 2024

Verified with

Brave	1.75.93 Chromium: 132.0.6834.46 (Official Build) nightly (arm64) 
Revision	dcc8451c2f80ef2c22db0285c002500b1f9bf4af
OS	macOS Version 15.2 (Build 24C100)

Encountered brave/brave-browser#42857 while testing.

Reproduced the issue using 1.74.26 Chromium: 132.0.6834.46 and STR from brave/brave-browser#42782 (comment) when selecting "Copy Link Address" and "Copy Image" from the right click context menu.

Copy Link Address Copy Image
Screenshot 2024-12-12 at 8 45 28 AM Screenshot 2024-12-12 at 8 45 42 AM

Using 1.75.93 Chromium: 132.0.6834.46 and same STR, confirmed no toast notifications for the same context menu selections.

Screen.Recording.2024-12-12.at.8.54.01.AM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copying a link shows Link Copied bubble
4 participants